[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interfac
From: |
Lluís Vilanova |
Subject: |
Re: [Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interface |
Date: |
Mon, 11 Sep 2017 01:15:19 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Emilio G Cota writes:
> On Wed, Sep 06, 2017 at 20:59:02 +0300, Lluís Vilanova wrote:
>> Signed-off-by: Lluís Vilanova <address@hidden>
>> ---
>> Makefile | 5 +++
>> configure | 1 +
>> instrument/Makefile.objs | 2 +
>> instrument/control.c | 28 +++++++++++++++++
>> instrument/control.h | 44 +++++++++++++++++++++++++++
>> instrument/control.inc.h | 25 ++++++++++++++++
>> instrument/error.h | 28 +++++++++++++++++
>> instrument/events.h | 37 +++++++++++++++++++++++
>> instrument/events.inc.h | 11 +++++++
> Am I the only one who finds this control vs. events division confusing?
Control is only for controlling instrumentation, and the header is used mainly
inside the instrumentation directory. Wheread the events header is later going
to be included in every file that needs to trigger an instrumentation event.
> Also, do we need all these many files, even for the public API?
The only other header, error.h, is later used in many other files.
> And why the .inc's?
To keep tidy headers with documentation, and the implementation details stashed
away on a separate file (like in the case of trace/).
> Thanks,
> E.
Cheers,
Lluis
- [Qemu-devel] [PATCH v4 05/20] instrument: [bsd-user] Add command line library loader, (continued)
- [Qemu-devel] [PATCH v4 05/20] instrument: [bsd-user] Add command line library loader, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 06/20] instrument: [softmmu] Add command line library loader, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 07/20] instrument: [qapi] Add library loader, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 08/20] instrument: [hmp] Add library loader, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 09/20] instrument: Add basic control interface, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 10/20] instrument: Add support for tracing events, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 11/20] instrument: Track vCPUs, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 12/20] instrument: Add event 'guest_cpu_enter', Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 13/20] instrument: Add event 'guest_cpu_exit', Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 14/20] instrument: Add event 'guest_cpu_reset', Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 15/20] trace: Introduce a proper structure to describe memory accesses, Lluís Vilanova, 2017/09/06
- [Qemu-devel] [PATCH v4 16/20] instrument: Add event 'guest_mem_before_trans', Lluís Vilanova, 2017/09/06