[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions
From: |
Kamil Rytarowski |
Subject: |
Re: [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions |
Date: |
Mon, 11 Sep 2017 23:44:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; NetBSD amd64; rv:52.0) Gecko/20100101 Thunderbird/52.1.0 |
On 11.09.2017 23:33, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> cleaning while here :)
>
> accel/tcg/user-exec.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/accel/tcg/user-exec.c b/accel/tcg/user-exec.c
> index 2a975eaf69..484a3f5f8f 100644
> --- a/accel/tcg/user-exec.c
> +++ b/accel/tcg/user-exec.c
> @@ -25,15 +25,6 @@
> #include "exec/cpu_ldst.h"
> #include "translate-all.h"
>
> -#undef EAX
> -#undef ECX
> -#undef EDX
> -#undef EBX
> -#undef ESP
> -#undef EBP
> -#undef ESI
> -#undef EDI
> -#undef EIP
> #ifdef __linux__
> #include <sys/ucontext.h>
> #endif
> @@ -131,6 +122,15 @@ static inline int handle_cpu_signal(uintptr_t pc,
> unsigned long address,
> }
>
> #if defined(__i386__)
> +#undef EAX
> +#undef ECX
> +#undef EDX
> +#undef EBX
> +#undef ESP
> +#undef EBP
> +#undef ESI
> +#undef EDI
> +#undef EIP
>
> #if defined(__NetBSD__)
> #include <ucontext.h>
>
Why to move under i386?
SmartOS pollutes namespace with these symbols on x86_64.
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v2 0/5] move user-exec, tcg-runtime, atomic_template.h to accel/tcg/, Philippe Mathieu-Daudé, 2017/09/11
- [Qemu-devel] [PATCH v2 1/5] tcg: Move softmmu_template.h to the accel/tcg/ folder, Philippe Mathieu-Daudé, 2017/09/11
- [Qemu-devel] [PATCH v2 2/5] tcg: move user-exec to accel/tcg/, Philippe Mathieu-Daudé, 2017/09/11
- [Qemu-devel] [PATCH v2 3/5] tcg: move tcg-runtime to accel/tcg/, Philippe Mathieu-Daudé, 2017/09/11
- [Qemu-devel] [PATCH v2 4/5] tcg: move atomic_template.h to accel/tcg/, Philippe Mathieu-Daudé, 2017/09/11
- [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions, Philippe Mathieu-Daudé, 2017/09/11
- Re: [Qemu-devel] [PATCH v2 5/5] tcg: restrict i386 regs definitions,
Kamil Rytarowski <=
- Re: [Qemu-devel] [PATCH v2 0/5] move user-exec, tcg-runtime, atomic_template.h to accel/tcg/, Richard Henderson, 2017/09/12