[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock update pri
From: |
James Hogan |
Subject: |
Re: [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock update prints to warn_report |
Date: |
Mon, 11 Sep 2017 22:43:43 +0100 |
User-agent: |
Mutt/1.7.2 (2016-11-26) |
On Mon, Sep 11, 2017 at 12:52:59PM -0700, Alistair Francis wrote:
> Convert the fprintf() messages in kvm_mips_update_state() to use
> warn_report() as they aren't errors, but are just warnings.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Cc: James Hogan <address@hidden>
Acked-by: James Hogan <address@hidden>
Thanks
James
> ---
>
> target/mips/kvm.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/target/mips/kvm.c b/target/mips/kvm.c
> index a23aa438d2..3b7b1d962a 100644
> --- a/target/mips/kvm.c
> +++ b/target/mips/kvm.c
> @@ -526,7 +526,7 @@ static void kvm_mips_update_state(void *opaque, int
> running, RunState state)
> if (!cs->vcpu_dirty) {
> ret = kvm_mips_save_count(cs);
> if (ret < 0) {
> - fprintf(stderr, "Failed saving count\n");
> + warn_report("Failed saving count");
> }
> }
> } else {
> @@ -535,14 +535,14 @@ static void kvm_mips_update_state(void *opaque, int
> running, RunState state)
> ret = kvm_mips_put_one_ureg64(cs, KVM_REG_MIPS_COUNT_RESUME,
> &count_resume);
> if (ret < 0) {
> - fprintf(stderr, "Failed setting COUNT_RESUME\n");
> + warn_report("Failed setting COUNT_RESUME");
> return;
> }
>
> if (!cs->vcpu_dirty) {
> ret = kvm_mips_restore_count(cs);
> if (ret < 0) {
> - fprintf(stderr, "Failed restoring count\n");
> + warn_report("Failed restoring count");
> }
> }
> }
> --
> 2.11.0
>
signature.asc
Description: Digital signature
- [Qemu-devel] [PATCH v4 0/8] More warning reporting fixed, Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 1/8] hw/i386: Improve some of the warning messages, Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 2/8] Convert remaining error_report() to warn_report(), Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 3/8] Convert single line fprintf(.../n) to warn_report(), Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 5/8] General warn report fixups, Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 6/8] target/mips: Convert VM clock update prints to warn_report, Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 4/8] Convert multi-line fprintf() to warn_report(), Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 8/8] Convert remaining single line fprintf() to warn_report(), Alistair Francis, 2017/09/11
- [Qemu-devel] [PATCH v4 7/8] Makefile: Remove libqemustub.a, Alistair Francis, 2017/09/11
- Re: [Qemu-devel] [PATCH v4 0/8] More warning reporting fixed, no-reply, 2017/09/11
- Re: [Qemu-devel] [PATCH v4 0/8] More warning reporting fixed, Paolo Bonzini, 2017/09/12
- Re: [Qemu-devel] [PATCH v4 0/8] More warning reporting fixed, Paolo Bonzini, 2017/09/12