qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into qtest


From: John Snow
Subject: Re: [Qemu-devel] [PATCH v7 26/38] libqtest: Merge qtest_end() into qtest_quit()
Date: Mon, 11 Sep 2017 20:31:36 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0


On 09/11/2017 01:20 PM, Eric Blake wrote:
> Rather than have two similar shutdown functions, where one requires
> the use of global_qtest in the header, it is better to have a single
> shutdown function that still takes care of cleaning up global_qtest
> if it is set.  All callers are updated.
> 
> Signed-off-by: Eric Blake <address@hidden>
> ---
>  tests/libqtest.h               | 11 -----------
>  tests/libqtest.c               |  6 +++++-
[...]
>  tests/fdc-test.c               |  2 +-
[...]
>  tests/ide-test.c               |  2 +-

Reviewed-by: John Snow <address@hidden>

The rest: "ACK." Change looks sane and I assume the rest of the patch is
fairly straightforward mechanical changes. Everything still compiles and
runs successfully.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]