[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with QPCIBus
From: |
Thomas Huth |
Subject: |
Re: [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with QPCIBus |
Date: |
Tue, 12 Sep 2017 09:05:44 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 11.09.2017 19:19, Eric Blake wrote:
> When initializing a QPCIBus, track which QTestState the bus is
> associated with (so that a later patch can then explicitly use
> that test state for all communication on the bus, rather than
> blindly relying on global_qtest). Update the initialization
> functions to take another parameter, and update all callers to
> pass in state (for now, most callers get away with passing the
> current global_qtest as the current state, although this required
> fixing the order of initialization to ensure qtest_start() is
> called before qpci_init*() in rtl8139-test, and provided an
> opportunity to pass in the allocator in e1000e-test).
>
> Touch up some allocations to use g_new0() rather than g_malloc()
> while in the area, and simplify some code (all implementations
> of QOSOps provide a .init_allocator() that never fails).
>
> Signed-off-by: Eric Blake <address@hidden>
Reviewed-by: Thomas Huth <address@hidden>
- [Qemu-devel] [PATCH v7 02/38] qtest: Don't perform side effects inside assertion, (continued)
- [Qemu-devel] [PATCH v7 02/38] qtest: Don't perform side effects inside assertion, Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 03/38] numa-test: Use hmp(), Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 05/38] libqtest: Remove dead qtest_instances variable, Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 01/38] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code, Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 04/38] tests: Clean up wait for event, Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 06/38] libqtest: Use qemu_strtoul(), Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 07/38] libqtest: Inline qtest_query_target_endianness(), Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 08/38] libqos: Track QTestState with QPCIBus, Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 09/38] libqos: Track QTestState with QVirtioBus, Eric Blake, 2017/09/11
- [Qemu-devel] [PATCH v7 10/38] libqos: Move/rename qpci_unplug_acpi_device_test() to pci.c, Eric Blake, 2017/09/11
[Qemu-devel] [PATCH v7 14/38] libqos: Use explicit QTestState for rtas operations, Eric Blake, 2017/09/11