[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition of a
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition of actions enum |
Date: |
Tue, 12 Sep 2017 14:02:15 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Thu, Sep 07, 2017 at 10:05:25AM +0200, Michal Privoznik wrote:
> We already have enum that enumerates all the actions that a
> watchdog can take when hitting its timeout: WatchdogAction.
> Use that instead of inventing our own.
>
> Signed-off-by: Michal Privoznik <address@hidden>
> ---
> hw/watchdog/watchdog.c | 45 ++++++++++++++++++++-------------------------
> hw/watchdog/wdt_diag288.c | 6 +++---
> include/sysemu/watchdog.h | 12 ++----------
> 3 files changed, 25 insertions(+), 38 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum, Michal Privoznik, 2017/09/07
- [Qemu-devel] [PATCH v5 1/3] qapi: Rename WatchdogExpirationAction enum, Michal Privoznik, 2017/09/07
- [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition of actions enum, Michal Privoznik, 2017/09/07
- Re: [Qemu-devel] [PATCH v5 2/3] watchdog.h: Drop local redefinition of actions enum,
Daniel P. Berrange <=
- [Qemu-devel] [PATCH v5 3/3] watchdog: Allow setting action on the fly, Michal Privoznik, 2017/09/07
- Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum, Eric Blake, 2017/09/07
- Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum, Markus Armbruster, 2017/09/07
- Re: [Qemu-devel] [PATCH v5 0/3] watchdog.h: Drop local redefinition of actions enum, Michal Privoznik, 2017/09/22