Re: [Qemu-devel] [PATCH v5 00/12] Convert over to use keycodemapdb

[Gerd Hoffmann]

  Hi,

> The keycodemapdb code is designed to be used as a git sub-module, it
> is
> not an external dependancy you need installed before use. In this
> version,
> however, the sub-module is not directly use. Instead all the
> generated
> files are checked into GIT. The downside to this is that we get an
> enourmous pile of errors from checkpatch.pl. The tool that generates
> the
> mapping files doesn't care about QEMU's coding style rules, because
> it is
> a general purpose tool intended for use by many different projects.
> 
> As such I'm not very happy about the idea of checking the generated
> files into
> GIT, and would prefer to go back to generating the files from the
> submodule
> on every build, as was done in v4.

The submodule approach has its share of issues too, just see how many
patch versions you've needed until patchew builds actually worked.  And
I guess lots of people have qemu build scripts which likewise need
adjustments.  Handling of release tarballs must be considered too.

I still think we should not require a checked out keycodemapdb
submodule.  But maybe it'll work better if we check in a copy of the
script and database instead of checking in the generated files.

cheers,
  Gerd