[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault
From: |
Greg Kurz |
Subject: |
Re: [Qemu-devel] [PATCH v3 0/3] hmp: fix "dump-quest-memory" segfault |
Date: |
Tue, 12 Sep 2017 16:46:44 +0200 |
On Tue, 12 Sep 2017 16:01:46 +0200
Laurent Vivier <address@hidden> wrote:
> Fix aarch64 and ppc when dump-guest-memory is
> used with none machine type and no CPU.
>
> The other machine types don't have the problem.
>
> Update test-hmp, to test none machine type
> with (2 MB) and without memory, and add a test
> to test dump-quest-memory without filter parameters
> (it needs the fix from Cornelia Huck to work)
>
> v3:
> - remove blank line after a comment
> - forbid memory dump when there is no CPU
>
So in the end, we would forbid dump on aarch64 and
ppc, while it is allowed on i386... I don't really
care about which behavior is more appropriate but
I guess they should be consistent at least.
Cc'ing some x86 and HMP people.
> v2:
> - add arm fix
> - update test-hmp
>
> Laurent Vivier (3):
> hmp: fix "dump-quest-memory" segfault (ppc)
> hmp: fix "dump-quest-memory" segfault (arm)
> tests/hmp: test "none" machine with memory
>
> target/arm/arch_dump.c | 11 +++++++++--
> target/ppc/arch_dump.c | 11 +++++++++--
> tests/test-hmp.c | 4 ++++
> 3 files changed, 22 insertions(+), 4 deletions(-)
>
pgpGiB0qDM5Te.pgp
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH v3 2/3] hmp: fix "dump-quest-memory" segfault (arm), (continued)