qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream


From: Halil Pasic
Subject: Re: [Qemu-devel] [PATCH 3/5] virtio-ccw: use ccw data stream
Date: Wed, 13 Sep 2017 13:36:24 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0


On 09/13/2017 11:58 AM, Cornelia Huck wrote:
> On Mon, 11 Sep 2017 20:14:59 +0200
> Halil Pasic <address@hidden> wrote:
> 
>> On 09/06/2017 02:42 PM, Cornelia Huck wrote:
>>>> @@ -488,7 +446,8 @@ static int virtio_ccw_cb(SubchDev *sch, CCW1 ccw)
>>>>          } else {
>>>>              virtio_bus_get_vdev_config(&dev->bus, vdev->config);
>>>>              /* XXX config space endianness */  
>>> Unrelated: That should be fine, I guess?
>>>   
>>
>> Would be pretty bad if it weren't. It's the responsibility of the
>> virtio device to give us the right endianness. We don't know the layout
>> so we could not fix it even if we had to. I guess this comment should be
>> removed.
> 
> Yes, please do so.
> 

Will do as a stand-alone patch.




reply via email to

[Prev in Thread] Current Thread [Next in Thread]