qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash


From: Philippe Mathieu-Daudé
Subject: Re: [Qemu-devel] [PATCH] sparc: Fix typedef clash
Date: Thu, 14 Sep 2017 10:39:00 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 09/14/2017 09:36 AM, Dr. David Alan Gilbert (git) wrote:
From: "Dr. David Alan Gilbert" <address@hidden>

Older compilers (rhel6) don't like redefinition of typedefs

Newer neither (clang-5)

    fatal error: redefinition of typedef [-Wtypedef-redefinition]

d61d1b20610


Fixes: 12a6c15ef31c98ecefa63e91ac36955383038384

you mean "missed in 12a6c15ef31c98ecefa63e91ac36955383038384"


Signed-off-by: Dr. David Alan Gilbert <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

---
  target/sparc/cpu.h | 4 ++--
  1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/sparc/cpu.h b/target/sparc/cpu.h
index b45cfb4708..1598f65927 100644
--- a/target/sparc/cpu.h
+++ b/target/sparc/cpu.h
@@ -240,7 +240,7 @@ typedef struct trap_state {
  #endif
  #define TARGET_INSN_START_EXTRA_WORDS 1
-typedef struct sparc_def_t {
+struct sparc_def_t {
      const char *name;
      target_ulong iu_version;
      uint32_t fpu_version;
@@ -254,7 +254,7 @@ typedef struct sparc_def_t {
      uint32_t features;
      uint32_t nwindows;
      uint32_t maxtl;
-} sparc_def_t;
+};
#define CPU_FEATURE_FLOAT (1 << 0)
  #define CPU_FEATURE_FLOAT128     (1 << 1)




reply via email to

[Prev in Thread] Current Thread [Next in Thread]