[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PULL 4/9] tests: Fix broken ivshmem-server-msi/-irq tests
From: |
Thomas Huth |
Subject: |
[Qemu-devel] [PULL 4/9] tests: Fix broken ivshmem-server-msi/-irq tests |
Date: |
Fri, 15 Sep 2017 10:02:24 +0200 |
Broken with commit b4ba67d9a7025 ("libqos: Change PCI accessors to take
opaque BAR handle") a while ago, but nobody noticed since the tests are
not run by default: The msix_pba_bar is not correctly initialized
anymore if bir_pba has the same value as bir_table. With this fix,
"make check SPEED=slow" should work fine again.
Fixes: b4ba67d9a702507793c2724e56f98e9b0f7be02b
Tested-by: Cornelia Huck <address@hidden>
Reviewed-by: David Gibson <address@hidden>
Reviewed-by: Laurent Vivier <address@hidden>
Signed-off-by: Thomas Huth <address@hidden>
---
tests/libqos/pci.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/tests/libqos/pci.c b/tests/libqos/pci.c
index df1f98e..0b73cb2 100644
--- a/tests/libqos/pci.c
+++ b/tests/libqos/pci.c
@@ -120,6 +120,8 @@ void qpci_msix_enable(QPCIDevice *dev)
bir_pba = table & PCI_MSIX_FLAGS_BIRMASK;
if (bir_pba != bir_table) {
dev->msix_pba_bar = qpci_iomap(dev, bir_pba, NULL);
+ } else {
+ dev->msix_pba_bar = dev->msix_table_bar;
}
dev->msix_pba_off = table & ~PCI_MSIX_FLAGS_BIRMASK;
@@ -138,8 +140,11 @@ void qpci_msix_disable(QPCIDevice *dev)
qpci_config_writew(dev, addr + PCI_MSIX_FLAGS,
val & ~PCI_MSIX_FLAGS_ENABLE);
+ if (dev->msix_pba_bar.addr != dev->msix_table_bar.addr) {
+ qpci_iounmap(dev, dev->msix_pba_bar);
+ }
qpci_iounmap(dev, dev->msix_table_bar);
- qpci_iounmap(dev, dev->msix_pba_bar);
+
dev->msix_enabled = 0;
dev->msix_table_off = 0;
dev->msix_pba_off = 0;
--
1.8.3.1
- [Qemu-devel] [PULL 0/9] Fixes and improvements for various qtests, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 1/9] tests: Introduce generic device hot-plug/hot-unplug functions, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 2/9] tests/test-hmp: Remove puv3 and tricore_testboard from the blacklist, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 3/9] tests/libqtest: Use a proper error message if QTEST_QEMU_BINARY is missing, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 4/9] tests: Fix broken ivshmem-server-msi/-irq tests,
Thomas Huth <=
- [Qemu-devel] [PULL 7/9] numa-test: Use hmp(), Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 6/9] qtest: Don't perform side effects inside assertion, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 5/9] test-qga: Kill broken and dead QGA_TEST_SIDE_EFFECTING code, Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 9/9] qtest: Avoid passing raw strings through hmp(), Thomas Huth, 2017/09/15
- [Qemu-devel] [PULL 8/9] libqtest: Remove dead qtest_instances variable, Thomas Huth, 2017/09/15
- Re: [Qemu-devel] [PULL 0/9] Fixes and improvements for various qtests, Peter Maydell, 2017/09/15