Re: [Qemu-devel] [PATCH 1/4] ppc/kvm: drop kvmppc_has_cap_htab_fd()

[Thomas Huth]

On 15.09.2017 15:15, Greg Kurz wrote:
> It never got used since its introduction (commit 7c43bca004af).
> 
> Signed-off-by: Greg Kurz <address@hidden>
> ---
>  target/ppc/kvm.c     |    5 -----
>  target/ppc/kvm_ppc.h |    6 ------
>  2 files changed, 11 deletions(-)
> 
> diff --git a/target/ppc/kvm.c b/target/ppc/kvm.c
> index 1deaf106d2b9..00d7029b8d7a 100644
> --- a/target/ppc/kvm.c
> +++ b/target/ppc/kvm.c
> @@ -2448,11 +2448,6 @@ bool kvmppc_has_cap_epr(void)
>      return cap_epr;
>  }
>  
> -bool kvmppc_has_cap_htab_fd(void)
> -{
> -    return cap_htab_fd;
> -}
> -
>  bool kvmppc_has_cap_fixup_hcalls(void)
>  {
>      return cap_fixup_hcalls;
> diff --git a/target/ppc/kvm_ppc.h b/target/ppc/kvm_ppc.h
> index f780e6ec7b72..08aab46c5a56 100644
> --- a/target/ppc/kvm_ppc.h
> +++ b/target/ppc/kvm_ppc.h
> @@ -51,7 +51,6 @@ uint64_t kvmppc_rma_size(uint64_t current_size, unsigned 
> int hash_shift);
>  #endif /* !CONFIG_USER_ONLY */
>  bool kvmppc_has_cap_epr(void);
>  int kvmppc_define_rtas_kernel_token(uint32_t token, const char *function);
> -bool kvmppc_has_cap_htab_fd(void);
>  int kvmppc_get_htab_fd(bool write);
>  int kvmppc_save_htab(QEMUFile *f, int fd, size_t bufsize, int64_t max_ns);
>  int kvmppc_load_htab_chunk(QEMUFile *f, int fd, uint32_t index,
> @@ -246,11 +245,6 @@ static inline int 
> kvmppc_define_rtas_kernel_token(uint32_t token,
>      return -1;
>  }
>  
> -static inline bool kvmppc_has_cap_htab_fd(void)
> -{
> -    return false;
> -}
> -
>  static inline int kvmppc_get_htab_fd(bool write)
>  {
>      return -1;
> 

Reviewed-by: Thomas Huth <address@hidden>