[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [PATCH] MAINTAINERS: Add Python scripts |
Date: |
Mon, 18 Sep 2017 10:40:53 +0100 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Sep 15, 2017 at 09:38:32PM -0300, Eduardo Habkost wrote:
> On Fri, Sep 15, 2017 at 08:17:18PM -0400, John Snow wrote:
> >
> >
> > On 09/15/2017 07:07 PM, Eduardo Habkost wrote:
> > > Cleber and I are volunteering to review and queue patches for the
> > > Python scripts and modules in scripts/.
> > >
> > > I'm setting "M: Odd fixes" because not all scripts are actively
> > > maintained.
> > >
> > > Signed-off-by: Eduardo Habkost <address@hidden>
> > > ---
> > > Even before this patch is merged, I plan to send a pull request
> > > including some patches for the Python code soon.
> > > ---
> > > MAINTAINERS | 7 +++++++
> > > 1 file changed, 7 insertions(+)
> > >
> > > diff --git a/MAINTAINERS b/MAINTAINERS
> > > index 2c333aba21..2c3b8ecde7 100644
> > > --- a/MAINTAINERS
> > > +++ b/MAINTAINERS
> > > @@ -1390,6 +1390,13 @@ S: Maintained
> > > F: include/sysemu/cryptodev*.h
> > > F: backends/cryptodev*.c
> > >
> > > +Python scripts
> > > +M: Eduardo Habkost <address@hidden>
> > > +M: Cleber Rosa <address@hidden>
> > > +S: Odd fixes
> > > +F: scripts/qmp/*
> > > +F: scripts/*.py
> > > +
> > > QAPI
> > > M: Markus Armbruster <address@hidden>
> > > M: Michael Roth <address@hidden>
> > >
> >
> > I rather like the thought of having dedicated Python maintainers who can
> > review python code with an eye for what is idiomatic. I am fairly
> > certain the python I write is functional, but I'm rarely sure it's what
> > a python programmer would do.
> >
> > I suppose you are intentionally omitting any python that exists as part
> > of the test infrastructure, however?
>
> Initially, yes. I was trying to include only the stuff we were
> actively maintaining. But later I decided to use "S: Odd fixes"
> instead of "S: Maintained", so I guess it won't hurt to include
> this:
>
Reviewed-by: Stefan Hajnoczi <address@hidden>