Re: [Qemu-devel] [PATCH qemu v3 00/13] memory: Reduce memory use

[Paolo Bonzini]

On 18/09/2017 12:16, Alexey Kardashevskiy wrote:
> This was inspired by https://bugzilla.redhat.com/show_bug.cgi?id=1481593
> Previous versions:
> v1: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg01559.html
> v2: https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04069.html
> 
> This patchset tries to reduce amount of memory used by FlatViews
> and tries share as many FVs between address spaces as possible.
> 
> Changelog:
> v3:
> * addressed comments from v2, mainly simplified the code

Looks almost ready.  I had a couple comments on patch 11.  However, if
they are wrong, I can just queue patches 2-13 immediately.  Your work on
other optimizations can then continue on top.

Thanks!

Paolo

> v2:
> * total rework
> 
> 
> 
> 
> This is based on sha1
> 4f2058ded4 Peter Maydell "Merge remote-tracking branch 
> 'remotes/rth/tags/pull-tcg-20170917' into staging".
> 
> Please comment. Thanks.
> 
> 
> 
> Alexey Kardashevskiy (13):
>   memory: Postpone flatview and dispatch tree building till all devices
>     are added
>   exec: Explicitely export target AS from
>     address_space_translate_internal
>   memory: Open code FlatView rendering
>   memory: Move FlatView allocation to a helper
>   memory: Move AddressSpaceDispatch from AddressSpace to FlatView
>   memory: Remove AddressSpace pointer from AddressSpaceDispatch
>   memory: Switch memory from using AddressSpace to FlatView
>   memory: Cleanup after switching to FlatView
>   memory: Rename mem_begin/mem_commit/mem_add helpers
>   memory: Store physical root MR in FlatView
>   memory: Share FlatView's and dispatch trees between address spaces
>   memory: Get rid of address_space_init_shareable
>   memory: Add flat views to HMP "info mtree"
> 
>  include/exec/memory-internal.h |  16 +-
>  include/exec/memory.h          |  76 +++++-----
>  include/hw/arm/armv7m.h        |   2 +-
>  cpus.c                         |   5 +-
>  exec.c                         | 330 
> +++++++++++++++++++++++++----------------
>  hw/arm/armv7m.c                |   9 +-
>  hw/intc/openpic_kvm.c          |   2 +-
>  memory.c                       | 271 +++++++++++++++++++++++----------
>  monitor.c                      |   3 +-
>  target/arm/cpu.c               |  16 +-
>  target/i386/cpu.c              |   5 +-
>  vl.c                           |   9 ++
>  hmp-commands-info.hx           |   7 +-
>  13 files changed, 478 insertions(+), 273 deletions(-)
>