[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] s390x/cpu: expose the guest crash information
|
From: |
Christian Borntraeger |
|
Subject: |
Re: [Qemu-devel] [PATCH] s390x/cpu: expose the guest crash information |
|
Date: |
Mon, 18 Sep 2017 19:23:13 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.0 |
On 09/18/2017 07:12 PM, Eric Blake wrote:
> On 09/18/2017 11:33 AM, Christian Borntraeger wrote:
>> From: Jing Liu <address@hidden>
>>
>> This patch is the s390 implementation of guest crash information, similar
>> to commit d187e08dc4 ("i386/cpu: add crash-information QOM property") and
>> the related commits. We will detect several crash reasons, with the
>> "disabled wait" being the most important one, since this is used by all
>> s390 guests as a "panic like" notification.
>>
>
>> +
>> +##
>> +# @GuestPanicInformationKVMS390:
>> +#
>> +# KVM-S390 specific guest panic information (PSW)
>> +#
>> +# Since: 2.11
>> +##
>> +{'struct': 'GuestPanicInformationKVMS390',
>> + 'data': { 'psw_mask': 'uint64',
>> + 'psw_addr': 'uint64',
>
> New interfaces should favor '-' over '_'; is there any reason we can't
> name these 'psw-mask' and 'pws-addr'?
Can change.