Re: [Qemu-devel] [PATCH v2 1/1] target/xtensa: Use the pre-defined MEMTXATTRS_UNSPECIFIED macro

[Alistair Francis]

On Fri, Sep 15, 2017 at 3:37 PM, Max Filippov <address@hidden> wrote:
> On Fri, Sep 15, 2017 at 2:56 PM, Alistair Francis
> <address@hidden> wrote:
>> Instead of using the hardcoded (MemTxAttrs){0} for no memory attributes
>> let's use the already defined MEMTXATTRS_UNSPECIFIED macro instead.
>>
>> This is technically a change of behaviour as MEMTXATTRS_UNSPECIFIED sets
>> the unspecified field to 1, but it doesn't look like anything is
>> checking this field.
>>
>> Signed-off-by: Alistair Francis <address@hidden>
>> ---
>> V2:
>>  - Update commit message to indicate the change in behaviour
>>
>>  target/xtensa/op_helper.c | 4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> Acked-by: Max Filippov <address@hidden>

Thanks Max,

Are you going to take this Max? Otherwise can it go through Peter?

Thanks,
Alistair

>
> --
> Thanks.
> -- Max