Re: [Qemu-devel] [PATCH v3 0/6] Convert to realize and improve error handling

[John Snow]

On 09/18/2017 10:05 AM, Mao Zhongyi wrote:
> This series mainly implements the conversions of ide, floppy and nvme
> device to realize. Add some error handling messages and remove the local
> variable local_err, use errp to propagate the error directly. Also
> fix the unusual function name.
> 
> v3:
>   -patch1: update the test output in 051  [John Snow] 
>   -patch2: update the test putput in 172  [John Snow]
> 
> v2:
>   -use bool as the return type instead of int. [Markus Armbruster & Stefan 
> Hajnoczi]
> 
> Cc: John Snow <address@hidden>
> Cc: Kevin Wolf <address@hidden>
> Cc: Max Reitz <address@hidden>
> Cc: Keith Busch <address@hidden>
> Cc: Stefan Hajnoczi <address@hidden>
> Cc: "Michael S. Tsirkin" <address@hidden>
> Cc: Paolo Bonzini <address@hidden>
> Cc: Gerd Hoffmann <address@hidden>
> Cc: Markus Armbruster <address@hidden>
> 
> Mao Zhongyi (6):
>   hw/ide: Convert DeviceClass init to realize
>   hw/block/fdc: Convert to realize
>   hw/block/nvme: Convert to realize
>   hw/block: Fix the return type
>   hw/block: Use errp directly rather than local_err
>   dev-storage: Fix the unusual function name
> 
>  hw/block/block.c                | 15 ++++---
>  hw/block/dataplane/virtio-blk.c | 12 +++---
>  hw/block/dataplane/virtio-blk.h |  2 +-
>  hw/block/fdc.c                  | 48 +++++++++------------
>  hw/block/nvme.c                 | 24 +++++------
>  hw/block/virtio-blk.c           | 17 +++-----
>  hw/ide/core.c                   |  7 +--
>  hw/ide/qdev.c                   | 94 
> +++++++++++++++++++----------------------
>  hw/scsi/scsi-disk.c             | 13 ++----
>  hw/usb/dev-storage.c            | 29 ++++++-------
>  include/hw/block/block.h        |  4 +-
>  include/hw/ide/internal.h       |  5 ++-
>  tests/qemu-iotests/051.pc.out   | 10 +----
>  tests/qemu-iotests/172.out      |  8 ----
>  14 files changed, 127 insertions(+), 161 deletions(-)
> 

Hi Mao Zhongyi:

I've staged patches one and two here for my IDE pull request.

I think patches 3-6 here would belong to Kevin.

Thanks,
John