[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 2/4] s390x/css: use ccw data stream
From: |
Dong Jia Shi |
Subject: |
Re: [Qemu-devel] [PATCH v2 2/4] s390x/css: use ccw data stream |
Date: |
Tue, 19 Sep 2017 10:45:31 +0800 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
* Halil Pasic <address@hidden> [2017-09-13 13:50:27 +0200]:
> Replace direct access which implicitly assumes no IDA
> or MIDA with the new ccw data stream interface which should
> cope with these transparently in the future.
>
> Signed-off-by: Halil Pasic <address@hidden>
> ---
> hw/s390x/css.c | 9 +++++----
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/s390x/css.c b/hw/s390x/css.c
> index e8d2016563..6b0cd8861b 100644
> --- a/hw/s390x/css.c
> +++ b/hw/s390x/css.c
> @@ -890,6 +890,7 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr
> ccw_addr,
> }
>
> /* Look at the command. */
> + ccw_dstream_init(&sch->cds, &ccw, &(sch->orb));
> switch (ccw.cmd_code) {
> case CCW_CMD_NOOP:
> /* Nothing to do. */
> @@ -903,8 +904,8 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr
> ccw_addr,
> }
> }
> len = MIN(ccw.count, sizeof(sch->sense_data));
> - cpu_physical_memory_write(ccw.cda, sch->sense_data, len);
> - sch->curr_status.scsw.count = ccw.count - len;
> + ccw_dstream_write_buf(&sch->cds, sch->sense_data, len);
> + sch->curr_status.scsw.count = ccw_dstream_residual_count(&sch->cds);
> memset(sch->sense_data, 0, sizeof(sch->sense_data));
> ret = 0;
> break;
> @@ -930,8 +931,8 @@ static int css_interpret_ccw(SubchDev *sch, hwaddr
> ccw_addr,
> } else {
> sense_id.reserved = 0;
> }
> - cpu_physical_memory_write(ccw.cda, &sense_id, len);
> - sch->curr_status.scsw.count = ccw.count - len;
> + ccw_dstream_write_buf(&sch->cds, &sense_id, len);
> + sch->curr_status.scsw.count = ccw_dstream_residual_count(&sch->cds);
> ret = 0;
> break;
> }
> --
> 2.13.5
>
Reviewed-by: Dong Jia Shi <address@hidden>
--
Dong Jia Shi
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, (continued)
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Cornelia Huck, 2017/09/14
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Dong Jia Shi, 2017/09/19
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Cornelia Huck, 2017/09/19
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Halil Pasic, 2017/09/19
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Cornelia Huck, 2017/09/19
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Halil Pasic, 2017/09/19
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Cornelia Huck, 2017/09/19
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Halil Pasic, 2017/09/19
- Re: [Qemu-devel] [PATCH v2 4/4] s390x/css: support ccw IDA, Pierre Morel, 2017/09/19
[Qemu-devel] [PATCH v2 2/4] s390x/css: use ccw data stream, Halil Pasic, 2017/09/13
[Qemu-devel] [PATCH v2 1/4] s390x/css: introduce css data stream, Halil Pasic, 2017/09/13