Re: [Qemu-devel] [RFC PATCH] vl.c: add is_system_on_chip flag to force board default cpu

[Peter Maydell]

On 18 September 2017 at 22:57, Philippe Mathieu-Daudé <address@hidden> wrote:
> add a property to restrict the CPU for SoCs once on machine creation and avoid
> duplicate code in each board.
>
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> Based-on: address@hidden
>
>  include/hw/boards.h |  3 +++
>  vl.c                | 11 +++++++++++
>  2 files changed, 14 insertions(+)
>
> diff --git a/include/hw/boards.h b/include/hw/boards.h
> index 6b67adaef6..20dc0a0ab9 100644
> --- a/include/hw/boards.h
> +++ b/include/hw/boards.h
> @@ -129,6 +129,8 @@ typedef struct {
>   *    specifies default CPU_TYPE, which will be used for parsing target
>   *    specific features and for creating CPUs if CPU name wasn't provided
>   *    explicitly at CLI
> + * @is_system_on_chip:
> + *    If true, board does not support other CPUs than default_cpu_type.

Being an SoC isn't the only reason a board might only support one
CPU type (perhaps it just never existed with other than a single
CPU soldered into it), so maybe a different name?

thanks
-- PMM