[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v4 2/3] intel_iommu, amd_iommu: Remove redundant
|
From: |
Eduardo Habkost |
|
Subject: |
Re: [Qemu-devel] [PATCH v4 2/3] intel_iommu, amd_iommu: Remove redundant object_dynamic_cast calls |
|
Date: |
Tue, 19 Sep 2017 11:22:38 -0300 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Mon, Sep 18, 2017 at 04:37:49PM +0200, Mohammed Gamal wrote:
> Now that the calling x86_iommu_realize() calls object_dynamic_cast(),
> doing the cast in amdvi_realize() and vtd_realize() is not needed.
>
> Use PC_MACHINE macro directly.
>
> Signed-off-by: Mohammed Gamal <address@hidden>
Reviewed-by: Eduardo Habkost <address@hidden>
I suggest squashing this into patch 1/3. It doesn't need to be a
separate patch.
--
Eduardo
- [Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when starting on non-PCI machines, Mohammed Gamal, 2017/09/18
- [Qemu-devel] [PATCH v4 2/3] intel_iommu, amd_iommu: Remove redundant object_dynamic_cast calls, Mohammed Gamal, 2017/09/18
- Re: [Qemu-devel] [PATCH v4 2/3] intel_iommu, amd_iommu: Remove redundant object_dynamic_cast calls,
Eduardo Habkost <=
- [Qemu-devel] [PATCH v4 1/3] x86_iommu: Move machine check to x86_iommu_realize(), Mohammed Gamal, 2017/09/18
- [Qemu-devel] [PATCH v4 3/3] x86_iommu: check if machine has PCI bus, Mohammed Gamal, 2017/09/18
- Re: [Qemu-devel] [PATCH v4 0/3] x86_iommu: Fix segfault when starting on non-PCI machines, Peter Xu, 2017/09/19