Re: [Qemu-devel] [PATCH v2 0/8] Support the Capstone disassembler

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Subject: [Qemu-devel] [PATCH v2 0/8] Support the Capstone disassembler
Message-id: address@hidden
Type: series

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
d0f53bd2e1 disas: Remove monitor_disas_is_physical
580ad9f05d ppc: Support Capstone in disas_set_info
5095c70945 arm: Support Capstone in disas_set_info
c359a651d4 i386: Support Capstone in disas_set_info
d443254743 disas: Support the Capstone disassembler library
65d9c3bff6 disas: Remove unused flags arguments
120ceff655 target/ppc: Convert to disas_set_info hook
180c4f43c2 target/i386: Convert to disas_set_info hook

=== OUTPUT BEGIN ===
Checking PATCH 1/8: target/i386: Convert to disas_set_info hook...
Checking PATCH 2/8: target/ppc: Convert to disas_set_info hook...
Checking PATCH 3/8: disas: Remove unused flags arguments...
Checking PATCH 4/8: disas: Support the Capstone disassembler library...
Checking PATCH 5/8: i386: Support Capstone in disas_set_info...
Checking PATCH 6/8: arm: Support Capstone in disas_set_info...
Checking PATCH 7/8: ppc: Support Capstone in disas_set_info...
Checking PATCH 8/8: disas: Remove monitor_disas_is_physical...
ERROR: space prohibited between function name and open parenthesis '('
#27: FILE: disas.c:517:
+physical_read_memory (bfd_vma memaddr, bfd_byte *myaddr, int length,

total: 1 errors, 0 warnings, 32 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden