qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCH] watchdog/aspeed: fix variable type to store rel


From: Richard Henderson
Subject: Re: [Qemu-devel] [PATCH] watchdog/aspeed: fix variable type to store reload value
Date: Tue, 19 Sep 2017 12:15:00 -0500
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 09/19/2017 06:17 AM, Cédric Le Goater wrote:
> +    uint64_t reload;
>  
>      if (pclk) {
>          reload = muldiv64(s->regs[WDT_RELOAD_VALUE], NANOSECONDS_PER_SECOND,
>                            s->pclk_freq);
>      } else {
> -        reload = s->regs[WDT_RELOAD_VALUE] * 1000;
> +        reload = s->regs[WDT_RELOAD_VALUE] * 1000UL;

UL does not help ilp32 hosts.  Need ULL or an explicit cast.

r~



reply via email to

[Prev in Thread] Current Thread [Next in Thread]