Re: [Qemu-devel] [PATCH 09/19] nvic: Make set_pending and clear_pending take a secure parameter

[Richard Henderson]

On 09/12/2017 01:13 PM, Peter Maydell wrote:
> Make the armv7m_nvic_set_pending() and armv7m_nvic_clear_pending()
> functions take a bool indicating whether to pend the secure
> or non-secure version of a banked interrupt, and update the
> callsites accordingly.
> 
> In most callsites we can simply pass the correct security
> state in; in a couple of cases we use TODO comments to indicate
> that we will return the code in a subsequent commit.
> 
> Signed-off-by: Peter Maydell <address@hidden>
> ---
>  target/arm/cpu.h      | 14 ++++++++++-
>  hw/intc/armv7m_nvic.c | 64 
> ++++++++++++++++++++++++++++++++++++++-------------
>  target/arm/helper.c   | 24 +++++++++++--------
>  hw/intc/trace-events  |  4 ++--
>  4 files changed, 77 insertions(+), 29 deletions(-)

Reviewed-by: Richard Henderson <address@hidden>

r~