qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio


From: Mark Cave-Ayland
Subject: Re: [Qemu-devel] [PATCHv2] macio: convert pmac_ide_ops from old_mmio
Date: Wed, 20 Sep 2017 07:28:27 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

On 20/09/17 07:00, David Gibson wrote:

> On Wed, Sep 20, 2017 at 06:56:37AM +0100, Mark Cave-Ayland wrote:
>> On 20/09/17 05:29, David Gibson wrote:
>>
>>> On Tue, Sep 19, 2017 at 09:02:54PM +0100, Mark Cave-Ayland wrote:
>>>> Signed-off-by: Mark Cave-Ayland <address@hidden>
>>>
>>> This didn't apply for me.  Can you rebase on top of ppc-for-2.11, please.
>>
>> (goes and looks)
>>
>> Okay looks like the issue is that you're missing "[PATCH 3/8]
>> ppc/ide/macio: Add missing registers" from your queue - I see you
>> replied with an applied to ppc-2.11 email so I bet this got dropped on
>> rebase somewhere.
> 
> Oh, sorry.  Not sure how that happened.
> 
>> Can you try again with that patch added and then let me know if it still
>> doesn't work?
> 
> Uh.. I've lost track of it, I'm afraid.  Can you resend it and the
> ide_ops one as a series.

Done. BTW if possible can you keep them in a similar order, i.e. ensure
that "ppc/ide/macio: Add missing registers" comes before "ppc: Fix
OpenPIC model"? (See
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04397.html for
the full set).

This is because in my testing Linux will see the change in OpenPIC model
and try to access the new macio registers, and so if that patch isn't
there first then you end up with a hang on boot. Keeping the order will
help make things much easier for bisection.


ATB,

Mark.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]