[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/2] block/block-backend.c: remove blk_pread_unt
|
From: |
Kevin Wolf |
|
Subject: |
Re: [Qemu-devel] [PATCH 2/2] block/block-backend.c: remove blk_pread_unthrottled() |
|
Date: |
Wed, 20 Sep 2017 14:37:40 +0200 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
Am 20.09.2017 um 13:43 hat Manos Pitsidianakis geschrieben:
> blk_pread_unthrottled was used to bypass I/O throttling on the BlockBackend in
> the case of async I/O. This is not needed anymore and we can just call
> blk_pread() directly.
>
> Signed-off-by: Manos Pitsidianakis <address@hidden>
We already did a related commit to the same effect in block/io.c:
commit 90c78624f157ba41c3761c1a54864de03a7ec350
Author: Kevin Wolf <address@hidden>
Date: Thu Apr 7 18:33:29 2016 +0200
block: Don't disable I/O throttling on sync requests
We had to disable I/O throttling with synchronous requests
because we
didn't use to run timers in nested event loops when the code was
introduced. This isn't true any more, and throttling works just
fine
even when using the synchronous API.
The removed code is in fact dead code since commit a8823a3b
('block: Use
blk_co_pwritev() for blk_write()') because I/O throttling can
only be
set on the top layer, but BlockBackend always uses the coroutine
interface now instead of using the sync API emulation in
block.c.
Signed-off-by: Kevin Wolf <address@hidden>
Message-Id: <address@hidden>
Signed-off-by: Paolo Bonzini <address@hidden>
Acked-by: Stefan Hajnoczi <address@hidden>
Signed-off-by: Kevin Wolf <address@hidden>
The same reasoning (at least the first part) applies to this patch.
Reviewed-by: Kevin Wolf <address@hidden>