[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC v2 06/33] migration: reuse mis->userfault_quit_fd
|
From: |
Juan Quintela |
|
Subject: |
Re: [Qemu-devel] [RFC v2 06/33] migration: reuse mis->userfault_quit_fd |
|
Date: |
Wed, 20 Sep 2017 11:06:50 +0200 |
|
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) |
Peter Xu <address@hidden> wrote:
> @@ -448,8 +449,15 @@ static void *postcopy_ram_fault_thread(void *opaque)
> }
>
> if (pfd[1].revents) {
> - trace_postcopy_ram_fault_thread_quit();
> - break;
> + uint64_t tmp64 = 0;
> +
> + /* Consume the signal */
> + read(mis->userfault_event_fd, &tmp64, 8);
make: Entering directory '/scratch/qemu/next/all'
CC migration/postcopy-ram.o
/mnt/kvm/qemu/next/migration/postcopy-ram.c: In function
‘postcopy_ram_fault_thread’:
/mnt/kvm/qemu/next/migration/postcopy-ram.c:460:13: error: ignoring return
value of ‘read’, declared with attribute warn_unused_result
[-Werror=unused-result]
read(mis->userfault_event_fd, &tmp64, 8);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors