[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] ide: fix enum comparison for gcc 4.7
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH] ide: fix enum comparison for gcc 4.7 |
|
Date: |
Wed, 20 Sep 2017 14:48:46 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/20/2017 02:41 PM, John Snow wrote:
> Apparently GCC gets bent over comparing enum values against zero.
> Replace the conditional with something less readable.
>
> Signed-off-by: John Snow <address@hidden>
> ---
> hw/ide/core.c | 2 +-
> include/hw/ide/internal.h | 3 +--
> 2 files changed, 2 insertions(+), 3 deletions(-)
Unfortunate that the compiler conspires against aesthetics, but such is
life.
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature