[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] qcow2: fix return error code i
From: |
John Snow |
Subject: |
Re: [Qemu-devel] [Qemu-block] [PATCH 1/2] qcow2: fix return error code in qcow2_truncate() |
Date: |
Wed, 20 Sep 2017 16:17:29 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/20/2017 09:58 AM, Pavel Butsykin wrote:
> Signed-off-by: Pavel Butsykin <address@hidden>
> ---
> block/qcow2.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/block/qcow2.c b/block/qcow2.c
> index 2174a84d1f..8a4311d338 100644
> --- a/block/qcow2.c
> +++ b/block/qcow2.c
> @@ -3166,7 +3166,7 @@ static int qcow2_truncate(BlockDriverState *bs, int64_t
> offset,
> if (old_file_size < 0) {
> error_setg_errno(errp, -old_file_size,
> "Failed to inquire current file length");
> - return ret;
> + return old_file_size;
> }
>
> nb_new_data_clusters = DIV_ROUND_UP(offset - old_length,
> @@ -3195,7 +3195,7 @@ static int qcow2_truncate(BlockDriverState *bs, int64_t
> offset,
> if (allocation_start < 0) {
> error_setg_errno(errp, -allocation_start,
> "Failed to resize refcount structures");
> - return -allocation_start;
> + return allocation_start;
> }
>
> clusters_allocated = qcow2_alloc_clusters_at(bs, allocation_start,
>
Yikes...
Reviewed-by: John Snow <address@hidden>