Re: [Qemu-devel] [PATCH v3 5/5] s390x/css: support ccw IDA

[Cornelia Huck]

On Thu, 21 Sep 2017 08:50:36 +0800
Dong Jia Shi <address@hidden> wrote:

> * Halil Pasic <address@hidden> [2017-09-20 18:46:57 +0200]:

> > Thinking about this some more. Since in case of IDA we are guaranteed
> > to never cross a block boundary with a single IDAW we won't ever cross
> > block boundary. So we can do the check in ida_read_next_idaw by checking
> > bit 0x80000000 on the ccw->cda. So we could keep idaw_fmt2 and ccw_fmt1
> > local to ida_read_next_idaw and save one goto err. I think that would
> > look a bit nicer than what I have here in v3. Agree?  
> Agree. That would also do the check in the first place. Sounds better.

Can't argue with nicer code, either :) Looking forward to the next
version.