Re: [Qemu-devel] [RFC PATCH] NUMA: Enable adding NUMA node implicitly

[Dou Liyang]

Hi Igor,

At 09/21/2017 03:54 PM, Igor Mammedov wrote:
> On Thu, 21 Sep 2017 12:19:17 +0800

[...]

> I've meant something like that:
>
> parse_numa_opts() {
>     if (mc->auto_enable_numa_with_memhp == true) {
>         qemu_opts_parse_noisily(qemu_find_opts("numa"), "node", true);
>     }
> }

Oops, Understood!  ;-) .

> where x86 sets mc->auto_enable_numa_with_memhp to true by default
> and sets it to false for 2.10 and older machine types.
> It will allow individual machines to enable feature if they need it
> but prevent guest ABI breakage for old machine types
> (i.e. won't break migration)

Got it.

> grep source for 'pcmc->legacy_cpu_hotplug = true' to see how
> this compact stuff works.

OK. Thank you very much.

Thanks,
        dou