[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/2] 3270 improvements
From: |
Cornelia Huck |
Subject: |
Re: [Qemu-devel] [PATCH 0/2] 3270 improvements |
Date: |
Thu, 21 Sep 2017 12:48:24 +0200 |
On Thu, 21 Sep 2017 12:22:30 +0200
Halil Pasic <address@hidden> wrote:
> On 09/21/2017 11:24 AM, Cornelia Huck wrote:
> > On Wed, 20 Sep 2017 19:23:12 +0200
> > Halil Pasic <address@hidden> wrote:
> >
> >> Jason found some problems with 3270 which he traced down to insufficient
> >> output buffer size. I've looked into the underlying issue (and the
> >> relevant code) and I saw strange things. Among others an unreasonable
> >> assert requiring the payload of a ccw being less than some more or
> >> less arbitrary limit (dictated by the size of the output buffer).
> >>
> >> Because we were already considering converting 3270 to CcwDataStream I've
> >> decided to try do get rid of this strange limitation on the length of the
> >> writes too.
> >>
> >> This series depends on my IDA work, which can be found here:
> >> https://lists.nongnu.org/archive/html/qemu-devel/2017-09/msg03434.html.
> >>
> >> Halil Pasic (2):
> >> s390x/3270: IDA support for 3270 via CcwDataStream
> >> s390x/3270: handle writes of arbitrary length
> >>
> >> hw/char/terminal3270.c | 46
> >> +++++++++++++++++++++++++++------------------
> >> hw/s390x/3270-ccw.c | 4 ++--
> >> include/hw/s390x/3270-ccw.h | 5 ++---
> >> 3 files changed, 32 insertions(+), 23 deletions(-)
> >>
> >
> > Are you planning to do some further work on 3270, btw?
> >
>
> I did not. I jumped in because of IDA, and because I did
> not agree with increasing the buffer size to another arbitrary
> an value (and essentially keep the bug). I hope the original
> authors will do further polishing.
That was actually a plural 'you' (a pity that English uses the same
word for both...)
>
> I'm just curious, what's behind the question?
Just whether I can expect more 3270 changes in the future :) Things
like support for multiple devices, whatever. Mostly curiousity.
- Re: [Qemu-devel] [PATCH 1/2] s390x/3270: IDA support for 3270 via CcwDataStream, (continued)
[Qemu-devel] [PATCH 2/2] s390x/3270: handle writes of arbitrary length, Halil Pasic, 2017/09/20
Re: [Qemu-devel] [PATCH 0/2] 3270 improvements, no-reply, 2017/09/20
Re: [Qemu-devel] [PATCH 0/2] 3270 improvements, Cornelia Huck, 2017/09/21
Re: [Qemu-devel] [PATCH 0/2] 3270 improvements, Cornelia Huck, 2017/09/28