|
| From: | Paolo Bonzini |
| Subject: | Re: [Qemu-devel] [PATCH qemu v5 04/18] memory: Move AddressSpaceDispatch from AddressSpace to FlatView |
| Date: | Thu, 21 Sep 2017 13:51:40 +0200 |
| User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 21/09/2017 10:50, Alexey Kardashevskiy wrote:
> * since FlatView::rcu is used now to dispose FV, call_rcu() in
> address_space_update_topology() is replaced with direct call to
> flatview_unref()
Hmm, this is not correct, as you could have
thread 1 thread 2 RCU thread
-------------------------------------------------------------
rcu_read_lock
read as->current_map
set as->current_map
flatview_unref
'--> call_rcu
flatview_ref
rcu_read_unlock
flatview_destroy
I need to think a bit more about this (and possibly ask Paul...).
Paolo
| [Prev in Thread] | Current Thread | [Next in Thread] |