Re: [Qemu-devel] [PATCH 1/3] iothread: provide helpers for internal use

[Paolo Bonzini]

On 22/09/2017 12:16, Stefan Hajnoczi wrote:
> I suggest adding internal IOThreads alongside user-created IOThreads
> instead of hiding them.  IOThread also needs a bool user_created field
> and a UserCreatableClass->can_be_deleted() function:
> 
>   static bool iothread_can_be_deleted(UserCreatable *uc)
>   {
>       return IOTHREAD(uc)->user_created;
>   }
> 
> This way users cannot delete internal IOThreads.
> 
> But how should object ids be handled?  In theory existing -object
> iothread,id=<id> users could use any name.  How can QEMU generate ids
> for internal IOThreads without conflicting with existing users's ids?

I would add an 'internal' boolean to query-iothreads' response and a new
'show-internal' boolean to the command.  This way, applications that
request internal iothreads would know that the "primary key" is
(internal, id) rather than just the id.

Paolo