[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1] s390x/kvm: fix and cleanup storing CPU statu
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH v1] s390x/kvm: fix and cleanup storing CPU status |
|
Date: |
Fri, 22 Sep 2017 09:05:19 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/22/2017 08:18 AM, David Hildenbrand wrote:
> On 22.09.2017 15:12, Richard Henderson wrote:
>> I don't believe you need to use QEMU_PACKED. Unless the "addr" that's passed
>> in can really be arbitrary? (If so, the memory returned by
>> cpu_physical_memory_map will be unaligned and so we do need the PACKED to
>> force
>> the compiler to generate unaligned stores into the structure.)
>
> The address is either 0x1200 or it is masked with 0x7ffffe00u.
>
> So most probably this should be fine without QEMU_PACKED, right?
Yes.
r~