Re: [Qemu-devel] [PATCH v2 1/4] qom: provide root container for internal objs

[Daniel P. Berrange]

On Mon, Sep 25, 2017 at 09:14:21AM +0200, Andreas Färber wrote:
> Am 25.09.2017 um 08:37 schrieb Peter Xu:
> > We have object_get_objects_root() to keep user created objects, however
> > no place for objects that will be used internally.  Create such a
> > container for internal objects.
> > 
> > CC: Andreas Färber <address@hidden>
> > CC: Markus Armbruster <address@hidden>
> > CC: Paolo Bonzini <address@hidden>
> > Suggested-by: Daniel P. Berrange <address@hidden>
> > Signed-off-by: Peter Xu <address@hidden>
> > ---
> >  include/qom/object.h | 10 ++++++++++
> >  qom/object.c         |  5 +++++
> >  2 files changed, 15 insertions(+)
> > 
> > diff --git a/include/qom/object.h b/include/qom/object.h
> > index f3e5cff..f567052 100644
> > --- a/include/qom/object.h
> > +++ b/include/qom/object.h
> > @@ -1214,6 +1214,16 @@ Object *object_get_root(void);
> >  Object *object_get_objects_root(void);
> >  
> >  /**
> > + * object_get_internal_root:
> > + *
> > + * Get the container object that holds internally used object
> > + * instances. This is the object at path "/internal-objects"
> > + *
> > + * Returns: the internal object container
> > + */
> > +Object *object_get_internal_root(void);
> > +
> > +/**
> >   * object_get_canonical_path_component:
> >   *
> >   * Returns: The final component in the object's canonical path.  The 
> > canonical
> > diff --git a/qom/object.c b/qom/object.c
> > index 3e18537..857cee7 100644
> > --- a/qom/object.c
> > +++ b/qom/object.c
> > @@ -1370,6 +1370,11 @@ Object *object_get_objects_root(void)
> >      return container_get(object_get_root(), "/objects");
> >  }
> >  
> > +Object *object_get_internal_root(void)
> > +{
> > +    return container_get(object_get_root(), "/internal-objects");
> 
> Whatever you expose in the QOM tree is no longer internal. Other name?

I guess the key concept trying to be expressed is that this will hold
objects created internally by QEMU code, in response to other configuration
input, as distinct from objects created externally by the user via -object.

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|