Re: [Qemu-devel] [PATCH v2 4/4] iothread: delay the context release to finalize

[Stefan Hajnoczi]

On Mon, Sep 25, 2017 at 02:37:29PM +0800, Peter Xu wrote:
> When gcontext is used with iothread, the context will be destroyed
> during iothread_stop().  That's not good since sometimes we would like
> to keep the resources until iothread is destroyed, but we may want to
> stop the thread before that point.
> 
> Delay the destruction of gcontext to iothread finalize.  Then we can do:
> 
>   iothread_stop(thread);
>   some_cleanup_on_resources();
>   iothread_destroy(thread);
> 
> We may need this patch if we want to run chardev IOs in iothreads and
> hopefully clean them up correctly.  For more specific information,
> please see 2b316774f6 ("qemu-char: do not operate on sources from
> finalize callbacks").
> 
> Signed-off-by: Peter Xu <address@hidden>
> ---
>  iothread.c | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <address@hidden>