[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int
|
From: |
Dr. David Alan Gilbert |
|
Subject: |
Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int |
|
Date: |
Mon, 25 Sep 2017 14:25:15 +0100 |
|
User-agent: |
Mutt/1.8.3 (2017-05-23) |
* Richard Henderson (address@hidden) wrote:
> On 09/25/2017 06:29 AM, Dr. David Alan Gilbert (git) wrote:
> > Modify the pre_save method on VMStateDescription to return an int
> > rather than void so that it potentially can fail.
>
> What does the int value signify?
0 is success, anything else is a failure; typically -errno.
> Why not a bool?
Consistency with pre_load, post_load, put and get methods
that are already int.
Dave
>
> r~
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK
- [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in vmstate_save_state, (continued)
- [Qemu-devel] [PATCH v2 2/6] migration: check pre_save return in vmstate_save_state, Dr. David Alan Gilbert (git), 2017/09/25
- [Qemu-devel] [PATCH v2 3/6] migration: Check field save returns, Dr. David Alan Gilbert (git), 2017/09/25
- [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int, Dr. David Alan Gilbert (git), 2017/09/25
- Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int, Peter Xu, 2017/09/25
- Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int, Cornelia Huck, 2017/09/26
- Re: [Qemu-devel] [PATCH v2 1/6] migration: pre_save return int, Juan Quintela, 2017/09/27
- [Qemu-devel] [PATCH v2 4/6] migration: wire vmstate_save_state errors up to vmstate_subsection_save, Dr. David Alan Gilbert (git), 2017/09/25
- [Qemu-devel] [PATCH v2 5/6] migration: Route errors up through vmstate_save, Dr. David Alan Gilbert (git), 2017/09/25