qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-devel] ping Re: [PATCH v7 03/16] migration: split common postc


From: Vladimir Sementsov-Ogievskiy
Subject: Re: [Qemu-devel] ping Re: [PATCH v7 03/16] migration: split common postcopy out of ram postcopy
Date: Mon, 25 Sep 2017 17:31:44 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0

25.09.2017 16:23, Kevin Wolf wrote:
Am 20.09.2017 um 13:45 hat Juan Quintela geschrieben:
"Dr. David Alan Gilbert" <address@hidden> wrote:
* Vladimir Sementsov-Ogievskiy (address@hidden) wrote:
ping for 1-3
Can we merge them?
I see all of them have R-b's; so lets try and put them in the next
migration merge.

Quintela: Sound good?
Yeap.
This patch broke qemu-iotests 181 ('Test postcopy live migration with
shared storage'):

--- /home/kwolf/source/qemu/tests/qemu-iotests/181.out  2017-06-16 
19:19:53.000000000 +0200
+++ 181.out.bad 2017-09-25 15:20:40.787582000 +0200
@@ -21,18 +21,16 @@
  === Do some I/O on the destination ===
QEMU X.Y.Z monitor - type 'help' for more information
-(qemu) qemu-io disk "read -P 0x55 0 64k"
+(qemu) QEMU_PROG: Expected vmdescription section, but got 0
+QEMU_PROG: Failed to get "write" lock
+Is another process using the image?
+qemu-io disk "read -P 0x55 0 64k"
  read 65536/65536 bytes at offset 0
  64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
  (qemu)
  (qemu) qemu-io disk "write -P 0x66 1M 64k"
-wrote 65536/65536 bytes at offset 1048576
-64 KiB, X ops; XX:XX:XX.X (XXX YYY/sec and XXX ops/sec)
-
-=== Shut down and check image ===
-
-(qemu) quit
-(qemu)
-(qemu) quit
-No errors were found on the image.
-*** done
+QEMU_PROG: block/io.c:1359: bdrv_aligned_pwritev: Assertion `child->perm & 
BLK_PERM_WRITE' failed.
+./common.config: Aborted                 (core dumped) ( if [ -n 
"${QEMU_NEED_PID}" ]; then
+echo $BASHPID > "${QEMU_TEST_DIR}/qemu-${_QEMU_HANDLE}.pid";
+fi; exec "$QEMU_PROG" $QEMU_OPTIONS "$@" )
+Timeout waiting for ops/sec on handle 1

Not sure about locking (don't see this error on my old kernel without OFD locking), but it looks like that 181 test should be fixed to set postcopy-ram capability on target too (which was considered as correct way on list)

--
Best regards,
Vladimir




reply via email to

[Prev in Thread] Current Thread [Next in Thread]