Re: [Qemu-devel] [PATCH v2] qdev: Mark devices as non-hotpluggable by default

[Peter Maydell]

On 25 September 2017 at 16:19, Thomas Huth <address@hidden> wrote:
> Not sure whether this works for the virtio-xxx-device devices,
> though, since they are marked as user_creatable = true currently...

That's deliberate -- for the arm boards with virtio-mmio
the board creates a bunch of virtio-mmio transports and the
virtio-foo-device can be user created to plug into those.

If overall trying to do the 'right thing' is tricky here
then perhaps we can start by flipping the default to
not-hotpluggable and marking some devices hotpluggable
that in theory shouldn't be with a comment about why.

Incidentally I think there's still some advantage in the
"created as part of some other device" devices having
to be explicitly marked hotpluggable, because those
devices do still need some specific code in them to
handle it (ie code to release the resources that are
created in the device's realize method).

thanks
-- PMM