[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicem
From: |
Anthony PERARD |
Subject: |
Re: [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown |
Date: |
Mon, 25 Sep 2017 17:32:29 +0100 |
User-agent: |
Mutt/1.9.1 (2017-09-22) |
On Fri, Sep 15, 2017 at 07:09:58PM +0100, Ian Jackson wrote:
> xc_interface_open etc. is not going to work if we have dropped
> privilege, but xendevicemodel_shutdown will if everything is new
> enough.
>
> Signed-off-by: Ian Jackson <address@hidden>
> ---
> hw/i386/xen/xen-hvm.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/i386/xen/xen-hvm.c b/hw/i386/xen/xen-hvm.c
> index 83420cd..639425a 100644
> --- a/hw/i386/xen/xen-hvm.c
> +++ b/hw/i386/xen/xen-hvm.c
> @@ -1386,9 +1386,18 @@ void destroy_hvm_domain(bool reboot)
> {
> xc_interface *xc_handle;
> int sts;
> + int rc;
>
> unsigned int reason = reboot ? SHUTDOWN_reboot : SHUTDOWN_poweroff;
>
> + if (xen_dmod) {
> + rc = xendevicemodel_shutdown(xen_dmod, xen_domid, reason);
xendevicemodel_shutdown is going to need a compatibility stub in
xen_common.h.
> + if (!rc)
> + return;
> + perror("xendevicemodel_shutdown failed");
> + /* well, try the old thing then */
> + }
> +
> xc_handle = xc_interface_open(0, 0, 0);
> if (xc_handle == NULL) {
> fprintf(stderr, "Cannot acquire xenctrl handle\n");
--
Anthony PERARD
- Re: [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore, (continued)
Re: [Qemu-devel] [PATCH RFC 1/6] xen: link against xentoolcore, Anthony PERARD, 2017/09/25
[Qemu-devel] [PATCH RFC 4/6] xen: destroy_hvm_domain: Move reason into a variable, Ian Jackson, 2017/09/15
[Qemu-devel] [PATCH RFC 2/6] xen: defer call to xen_restrict until running, Ian Jackson, 2017/09/15
[Qemu-devel] [PATCH RFC 3/6] xen: restrict: use xentoolcore_restrict_all, Ian Jackson, 2017/09/15
[Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown, Ian Jackson, 2017/09/15
- Re: [Qemu-devel] [PATCH RFC 5/6] xen: destroy_hvm_domain: Try xendevicemodel_shutdown,
Anthony PERARD <=
Re: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements, no-reply, 2017/09/15
Re: [Qemu-devel] [PATCH RFC 0/6] xen: xen-domid-restrict improvements, no-reply, 2017/09/15