[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs |
Date: |
Mon, 25 Sep 2017 15:47:37 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/25/2017 07:28 AM, Kevin Wolf wrote:
> We don't need to make any assumptions about the graph layout above the
> top node of the commit operation any more. Remove the use of
> bdrv_find_overlay() and related variables from the commit job code.
>
> bdrv_drop_intermediate() doesn't use the 'active' parameter any more, so
> we can just drop it.
>
> The overlay node was previously added to the block job to get a
> BLK_PERM_GRAPH_MOD. We really need to respect those permissions in
> bdrv_drop_intermediate() now, but as long as we haven't figured out yet
> how BLK_PERM_GRAPH_MOD is actually supposed to work, just leave a TODO
> comment there.
>
> With this change, it is now possible to perform another block job on an
> overlay node without conflicts. qemu-iotests 030 is changed accordingly.
>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
> include/block/block.h | 3 +--
> block.c | 6 +++--
> block/commit.c | 62
> ++++++++++++--------------------------------------
> tests/qemu-iotests/030 | 4 ----
> 4 files changed, 20 insertions(+), 55 deletions(-)
>
Reviewed-by: Eric Blake <address@hidden>
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
- [Qemu-devel] [PATCH 2/5] commit: Support multiple roots above top node, (continued)
- [Qemu-devel] [PATCH 2/5] commit: Support multiple roots above top node, Kevin Wolf, 2017/09/25
- [Qemu-devel] [PATCH 1/5] block: Introduce BdrvChildRole.update_filename, Kevin Wolf, 2017/09/25
- [Qemu-devel] [PATCH 3/5] qemu-iotests: Allow QMP pretty printing in common.qemu, Kevin Wolf, 2017/09/25
- [Qemu-devel] [PATCH 4/5] qemu-iotests: Test commit block job where top has two parents, Kevin Wolf, 2017/09/25
- [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs, Kevin Wolf, 2017/09/25
- Re: [Qemu-devel] [PATCH 5/5] commit: Remove overlay_bs,
Eric Blake <=
- Re: [Qemu-devel] [Qemu-block] [PATCH 0/5] commit: Support multiple roots above top node, John Snow, 2017/09/25