Re: [Qemu-devel] [PATCH v2] s390x/kvm: fix and cleanup storing CPU status

[Cornelia Huck]

On Fri, 22 Sep 2017 16:03:38 +0200
David Hildenbrand <address@hidden> wrote:

> env->psa is a 64bit value, while we copy 4 bytes into the save area,
> resulting always in 0 getting stored.
> 
> Let's try to reduce such errors by using a proper structure. While at
> it, use correct cpu->be conversion (and get_psw_mask()), as we will be
> reusing this code for TCG soon.
> 
> Signed-off-by: David Hildenbrand <address@hidden>
> ---
> 
> v1 -> v2:
>  - dropped QEMU_PACKED
>  - Moved QEMU_BUILD_BUG_ON()
>  - Retested if it works now

Testing? What's going on here? :)

> 
>  target/s390x/kvm.c | 62 
> ++++++++++++++++++++++++++++++++++++------------------
>  1 file changed, 42 insertions(+), 20 deletions(-)

Thanks, applied.