Re: [Qemu-devel] [PATCH v4 3/5] virtio-ccw: use ccw data stream

[Halil Pasic]

On 09/26/2017 12:10 PM, Cornelia Huck wrote:
> On Fri, 22 Sep 2017 17:39:35 +0200
> Pierre Morel <address@hidden> wrote:
> 
>> On 21/09/2017 20:08, Halil Pasic wrote:
>>> Replace direct access which implicitly assumes no IDA
>>> or MIDA with the new ccw data stream interface which should
>>> cope with these transparently in the future.
>>>
>>> Signed-off-by: Halil Pasic <address@hidden>
>>> Reviewed-by: Pierre Morel<address@hidden>
>>> Reviewed-by: Dong Jia Shi <address@hidden>
>>> ---
>>>   hw/s390x/virtio-ccw.c | 155 
>>> +++++++++++++++-----------------------------------
>>>   1 file changed, 46 insertions(+), 109 deletions(-)
> 
>> LGTM.
>> Not testing the return value for ccw_dstream_read/write_buf() bother me 
>> but I can understand that you will modify this later.
>> May be a comment?
>> Not a strong opinion.
> 
> I can add "Note that checking the return code for ccw_dstream_* will be
> done in a follow-on patch."
> 

I'm fine with that.

>>
>> Reviewed-by: Pierre Morel<address@hidden>
>>
>>
> 
>