Re: [Qemu-devel] [PATCH 00/43] Windbg supporting

[no-reply]

Hi,

This series seems to have some coding style problems. See output below for
more information:

Type: series
Message-id: address@hidden
Subject: [Qemu-devel] [PATCH 00/43] Windbg supporting

=== TEST SCRIPT BEGIN ===
#!/bin/bash

BASE=base
n=1
total=$(git log --oneline $BASE.. | wc -l)
failed=0

git config --local diff.renamelimit 0
git config --local diff.renames True

commits="$(git log --format=%H --reverse $BASE..)"
for c in $commits; do
    echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..."
    if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then
        failed=1
        echo
    fi
    n=$((n+1))
done

exit $failed
=== TEST SCRIPT END ===

Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
e90de2cd8b windbg: implemented kd_api_query_memory
cc787ea88e windbg: implemented kd_api_fill_memory
8f32099c6f windbg: implemented kd_api_search_memory
942a29456c windbg: implemented kd_api_read_msr and kd_api_write_msr
59da3de182 windbg: implemented kd_api_get_version
35ce24ece7 windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory
c538b2666f windbg: implemented kd_api_read_io_space and kd_api_write_io_space
fa5f8f575d windbg: implemented kd_api_continue
3796c90193 windbg: debug exception subscribing
4181a26d64 windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint
88ae07e5aa windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove
69ce5a6bcf windbg: implemented windbg_set_dr7
c6e2a59342 windbg: implemented windbg_set_dr
e8c1591a65 windbg: implemented windbg_set_sr
73e0618e39 windbg: implemented windbg_write_ks_regs
666d60efe2 windbg: implemented windbg_read_ks_regs
b689fed4ef windbg: implemented windbg_write_context
6f91def62e windbg: implemented windbg_read_context
3a29cdd179 windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space
75b92618d1 windbg: implemented kd_api_get_context and kd_api_set_context
a87de92543 windbg: kernel's structures
4365ac1100 windbg: implemented kd_api_read_virtual_memory and 
kd_api_read_virtual_memory
70961d24a0 windbg: implemented windbg_process_manipulate_packet
b4bb899c02 windbg: implemented windbg_process_data_packet
fc8d3b584a windbg: implemented windbg_process_control_packet
b1cbb65c72 windbg: windbg_vm_stop
390f2f08d6 windbg: generate LoadSymbolsStateChange
cdfc1b40da windbg: generate ExceptionStateChange
8b2d5356c6 windbg: sized data buffer
d0a8435b8b windbg: init DBGKD_ANY_WAIT_STATE_CHANGE
1966388823 windbg: handler of parsing context
8d129875bf windbg: send data and control packets
59c56d64cc windbg: parsing data stream
971225acc1 windbg: structures for parsing data stream
99c412e9e0 windbg: handler of fs/gs register
c0a11c6325 windbg: hook to wrmsr operation
4c6fd55445 windbg: added chardev
72fcae8615 windbg: added WindbgState
8bf5d0742d windbg: added helper features
fc939ae043 windbg: added '-windbg' option
ac6608474a windbg: modified windbgkd.h
a60b823a5e windbg: added windbg's KD header file
03d0e9dab3 windbg: added empty windbgstub files

=== OUTPUT BEGIN ===
Checking PATCH 1/43: windbg: added empty windbgstub files...
ERROR: do not set execute permissions for source files
#28: FILE: include/exec/windbgstub-utils.h

ERROR: do not set execute permissions for source files
#52: FILE: include/exec/windbgstub.h

ERROR: do not set execute permissions for source files
#75: FILE: windbgstub-utils.c

ERROR: do not set execute permissions for source files
#93: FILE: windbgstub.c

total: 4 errors, 0 warnings, 76 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 2/43: windbg: added windbg's KD header file...
ERROR: do not set execute permissions for source files
#14: FILE: include/exec/windbgkd.h

ERROR: open brace '{' following struct go on the same line
#256: FILE: include/exec/windbgkd.h:238:
+typedef struct _KD_PACKET
+{

ERROR: open brace '{' following struct go on the same line
#268: FILE: include/exec/windbgkd.h:250:
+typedef struct _KD_CONTEXT
+{

ERROR: open brace '{' following struct go on the same line
#277: FILE: include/exec/windbgkd.h:259:
+typedef struct _X86_DBGKD_CONTROL_SET
+{

ERROR: open brace '{' following struct go on the same line
#285: FILE: include/exec/windbgkd.h:267:
+typedef struct _ALPHA_DBGKD_CONTROL_SET
+{

ERROR: open brace '{' following struct go on the same line
#290: FILE: include/exec/windbgkd.h:272:
+typedef struct _IA64_DBGKD_CONTROL_SET
+{

ERROR: open brace '{' following struct go on the same line
#297: FILE: include/exec/windbgkd.h:279:
+typedef struct _AMD64_DBGKD_CONTROL_SET
+{

ERROR: open brace '{' following struct go on the same line
#305: FILE: include/exec/windbgkd.h:287:
+typedef struct _ARM_DBGKD_CONTROL_SET
+{

ERROR: open brace '{' following struct go on the same line
#312: FILE: include/exec/windbgkd.h:294:
+typedef struct _DBGKD_ANY_CONTROL_SET
+{

ERROR: open brace '{' following union go on the same line
#314: FILE: include/exec/windbgkd.h:296:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#359: FILE: include/exec/windbgkd.h:341:
+typedef struct _DBGKM_EXCEPTION32
+{

ERROR: open brace '{' following struct go on the same line
#365: FILE: include/exec/windbgkd.h:347:
+typedef struct _DBGKM_EXCEPTION64
+{

ERROR: open brace '{' following struct go on the same line
#374: FILE: include/exec/windbgkd.h:356:
+typedef struct _X86_DBGKD_CONTROL_REPORT
+{

ERROR: open brace '{' following struct go on the same line
#388: FILE: include/exec/windbgkd.h:370:
+typedef struct _ALPHA_DBGKD_CONTROL_REPORT
+{

ERROR: open brace '{' following struct go on the same line
#394: FILE: include/exec/windbgkd.h:376:
+typedef struct _IA64_DBGKD_CONTROL_REPORT
+{

ERROR: open brace '{' following struct go on the same line
#400: FILE: include/exec/windbgkd.h:382:
+typedef struct _AMD64_DBGKD_CONTROL_REPORT
+{

ERROR: open brace '{' following struct go on the same line
#414: FILE: include/exec/windbgkd.h:396:
+typedef struct _ARM_DBGKD_CONTROL_REPORT
+{

ERROR: open brace '{' following struct go on the same line
#421: FILE: include/exec/windbgkd.h:403:
+typedef struct _DBGKD_ANY_CONTROL_REPORT
+{

ERROR: open brace '{' following union go on the same line
#423: FILE: include/exec/windbgkd.h:405:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#446: FILE: include/exec/windbgkd.h:428:
+typedef struct _DBGKD_PRINT_STRING
+{

ERROR: open brace '{' following struct go on the same line
#454: FILE: include/exec/windbgkd.h:436:
+typedef struct _DBGKD_GET_STRING
+{

ERROR: open brace '{' following struct go on the same line
#463: FILE: include/exec/windbgkd.h:445:
+typedef struct _DBGKD_DEBUG_IO
+{

ERROR: open brace '{' following union go on the same line
#468: FILE: include/exec/windbgkd.h:450:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#478: FILE: include/exec/windbgkd.h:460:
+typedef struct _DBGKD_COMMAND_STRING
+{

ERROR: open brace '{' following struct go on the same line
#488: FILE: include/exec/windbgkd.h:470:
+typedef struct _DBGKD_LOAD_SYMBOLS32
+{

ERROR: open brace '{' following struct go on the same line
#498: FILE: include/exec/windbgkd.h:480:
+typedef struct _DBGKD_LOAD_SYMBOLS64
+{

ERROR: open brace '{' following struct go on the same line
#511: FILE: include/exec/windbgkd.h:493:
+typedef struct _DBGKD_WAIT_STATE_CHANGE32
+{

ERROR: open brace '{' following union go on the same line
#519: FILE: include/exec/windbgkd.h:501:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#526: FILE: include/exec/windbgkd.h:508:
+typedef struct _DBGKD_WAIT_STATE_CHANGE64
+{

ERROR: open brace '{' following union go on the same line
#534: FILE: include/exec/windbgkd.h:516:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#541: FILE: include/exec/windbgkd.h:523:
+typedef struct _DBGKD_ANY_WAIT_STATE_CHANGE
+{

ERROR: open brace '{' following union go on the same line
#549: FILE: include/exec/windbgkd.h:531:
+    union
+    {

ERROR: open brace '{' following union go on the same line
#555: FILE: include/exec/windbgkd.h:537:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#565: FILE: include/exec/windbgkd.h:547:
+typedef struct _DBGKD_READ_MEMORY32
+{

ERROR: open brace '{' following struct go on the same line
#572: FILE: include/exec/windbgkd.h:554:
+typedef struct _DBGKD_READ_MEMORY64
+{

ERROR: open brace '{' following struct go on the same line
#579: FILE: include/exec/windbgkd.h:561:
+typedef struct _DBGKD_WRITE_MEMORY32
+{

ERROR: open brace '{' following struct go on the same line
#586: FILE: include/exec/windbgkd.h:568:
+typedef struct _DBGKD_WRITE_MEMORY64
+{

ERROR: open brace '{' following struct go on the same line
#593: FILE: include/exec/windbgkd.h:575:
+typedef struct _DBGKD_GET_CONTEXT
+{

ERROR: open brace '{' following struct go on the same line
#598: FILE: include/exec/windbgkd.h:580:
+typedef struct _DBGKD_SET_CONTEXT
+{

ERROR: open brace '{' following struct go on the same line
#603: FILE: include/exec/windbgkd.h:585:
+typedef struct _DBGKD_WRITE_BREAKPOINT32
+{

ERROR: open brace '{' following struct go on the same line
#609: FILE: include/exec/windbgkd.h:591:
+typedef struct _DBGKD_WRITE_BREAKPOINT64
+{

ERROR: open brace '{' following struct go on the same line
#615: FILE: include/exec/windbgkd.h:597:
+typedef struct _DBGKD_RESTORE_BREAKPOINT
+{

ERROR: open brace '{' following struct go on the same line
#620: FILE: include/exec/windbgkd.h:602:
+typedef struct _DBGKD_CONTINUE
+{

ERROR: open brace '{' following struct go on the same line
#626: FILE: include/exec/windbgkd.h:608:
+typedef struct _DBGKD_CONTINUE2
+{

ERROR: open brace '{' following union go on the same line
#629: FILE: include/exec/windbgkd.h:611:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#637: FILE: include/exec/windbgkd.h:619:
+typedef struct _DBGKD_READ_WRITE_IO32
+{

ERROR: open brace '{' following struct go on the same line
#644: FILE: include/exec/windbgkd.h:626:
+typedef struct _DBGKD_READ_WRITE_IO64
+{

ERROR: open brace '{' following struct go on the same line
#651: FILE: include/exec/windbgkd.h:633:
+typedef struct _DBGKD_READ_WRITE_IO_EXTENDED32
+{

ERROR: open brace '{' following struct go on the same line
#661: FILE: include/exec/windbgkd.h:643:
+typedef struct _DBGKD_READ_WRITE_IO_EXTENDED64
+{

ERROR: open brace '{' following struct go on the same line
#671: FILE: include/exec/windbgkd.h:653:
+typedef struct _DBGKD_READ_WRITE_MSR
+{

ERROR: open brace '{' following struct go on the same line
#678: FILE: include/exec/windbgkd.h:660:
+typedef struct _DBGKD_QUERY_SPECIAL_CALLS
+{

ERROR: open brace '{' following struct go on the same line
#683: FILE: include/exec/windbgkd.h:665:
+typedef struct _DBGKD_SET_SPECIAL_CALL32
+{

ERROR: open brace '{' following struct go on the same line
#688: FILE: include/exec/windbgkd.h:670:
+typedef struct _DBGKD_SET_SPECIAL_CALL64
+{

ERROR: open brace '{' following struct go on the same line
#693: FILE: include/exec/windbgkd.h:675:
+typedef struct _DBGKD_SET_INTERNAL_BREAKPOINT32
+{

ERROR: open brace '{' following struct go on the same line
#699: FILE: include/exec/windbgkd.h:681:
+typedef struct _DBGKD_SET_INTERNAL_BREAKPOINT64
+{

ERROR: open brace '{' following struct go on the same line
#705: FILE: include/exec/windbgkd.h:687:
+typedef struct _DBGKD_GET_INTERNAL_BREAKPOINT32
+{

ERROR: open brace '{' following struct go on the same line
#716: FILE: include/exec/windbgkd.h:698:
+typedef struct _DBGKD_GET_INTERNAL_BREAKPOINT64
+{

ERROR: open brace '{' following struct go on the same line
#727: FILE: include/exec/windbgkd.h:709:
+typedef struct _DBGKD_GET_VERSION32
+{

ERROR: open brace '{' following struct go on the same line
#745: FILE: include/exec/windbgkd.h:727:
+typedef struct _DBGKD_GET_VERSION64
+{

ERROR: open brace '{' following struct go on the same line
#763: FILE: include/exec/windbgkd.h:745:
+typedef struct _DBGKD_BREAKPOINTEX
+{

ERROR: open brace '{' following struct go on the same line
#769: FILE: include/exec/windbgkd.h:751:
+typedef struct _DBGKD_SEARCH_MEMORY
+{

ERROR: open brace '{' following union go on the same line
#771: FILE: include/exec/windbgkd.h:753:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#780: FILE: include/exec/windbgkd.h:762:
+typedef struct _DBGKD_GET_SET_BUS_DATA
+{

ERROR: open brace '{' following struct go on the same line
#789: FILE: include/exec/windbgkd.h:771:
+typedef struct _DBGKD_FILL_MEMORY
+{

ERROR: open brace '{' following struct go on the same line
#797: FILE: include/exec/windbgkd.h:779:
+typedef struct _DBGKD_QUERY_MEMORY
+{

ERROR: open brace '{' following struct go on the same line
#805: FILE: include/exec/windbgkd.h:787:
+typedef struct _DBGKD_SWITCH_PARTITION
+{

ERROR: open brace '{' following struct go on the same line
#813: FILE: include/exec/windbgkd.h:795:
+typedef struct _DBGKD_MANIPULATE_STATE32
+{

ERROR: open brace '{' following union go on the same line
#819: FILE: include/exec/windbgkd.h:801:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#848: FILE: include/exec/windbgkd.h:830:
+typedef struct _DBGKD_MANIPULATE_STATE64
+{

ERROR: open brace '{' following union go on the same line
#854: FILE: include/exec/windbgkd.h:836:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#884: FILE: include/exec/windbgkd.h:866:
+typedef struct _DBGKD_CREATE_FILE
+{

ERROR: open brace '{' following struct go on the same line
#895: FILE: include/exec/windbgkd.h:877:
+typedef struct _DBGKD_READ_FILE
+{

ERROR: open brace '{' following struct go on the same line
#902: FILE: include/exec/windbgkd.h:884:
+typedef struct _DBGKD_WRITE_FILE
+{

ERROR: open brace '{' following struct go on the same line
#909: FILE: include/exec/windbgkd.h:891:
+typedef struct _DBGKD_CLOSE_FILE
+{

ERROR: open brace '{' following struct go on the same line
#914: FILE: include/exec/windbgkd.h:896:
+typedef struct _DBGKD_FILE_IO
+{

ERROR: open brace '{' following union go on the same line
#918: FILE: include/exec/windbgkd.h:900:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#932: FILE: include/exec/windbgkd.h:914:
+typedef struct _DBGKD_REQUEST_BREAKPOINT
+{

ERROR: open brace '{' following struct go on the same line
#938: FILE: include/exec/windbgkd.h:920:
+typedef struct _DBGKD_RELEASE_BREAKPOINT
+{

ERROR: open brace '{' following struct go on the same line
#944: FILE: include/exec/windbgkd.h:926:
+typedef struct _DBGKD_CONTROL_REQUEST
+{

ERROR: open brace '{' following union go on the same line
#947: FILE: include/exec/windbgkd.h:929:
+    union
+    {

ERROR: open brace '{' following struct go on the same line
#957: FILE: include/exec/windbgkd.h:939:
+typedef struct _DBGKD_PRINT_TRACE
+{

ERROR: open brace '{' following struct go on the same line
#962: FILE: include/exec/windbgkd.h:944:
+typedef struct _DBGKD_TRACE_IO
+{

ERROR: open brace '{' following union go on the same line
#967: FILE: include/exec/windbgkd.h:949:
+   union
+   {

total: 83 errors, 0 warnings, 961 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 3/43: windbg: modified windbgkd.h...
Checking PATCH 4/43: windbg: added '-windbg' option...
Checking PATCH 5/43: windbg: added helper features...
ERROR: spaces required around that '*' (ctx:WxB)
#57: FILE: include/exec/windbgstub-utils.h:52:
+#define FIELD_P(type, field, ptr) ((typeof_field(type, field) *) (ptr))
                                                               ^

total: 1 errors, 0 warnings, 69 lines checked

Your patch has style problems, please review.  If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.

Checking PATCH 6/43: windbg: added WindbgState...
Checking PATCH 7/43: windbg: added chardev...
Checking PATCH 8/43: windbg: hook to wrmsr operation...
Checking PATCH 9/43: windbg: handler of fs/gs register...
Checking PATCH 10/43: windbg: structures for parsing data stream...
Checking PATCH 11/43: windbg: parsing data stream...
Checking PATCH 12/43: windbg: send data and control packets...
Checking PATCH 13/43: windbg: handler of parsing context...
Checking PATCH 14/43: windbg: init DBGKD_ANY_WAIT_STATE_CHANGE...
Checking PATCH 15/43: windbg: sized data buffer...
Checking PATCH 16/43: windbg: generate ExceptionStateChange...
Checking PATCH 17/43: windbg: generate LoadSymbolsStateChange...
Checking PATCH 18/43: windbg: windbg_vm_stop...
Checking PATCH 19/43: windbg: implemented windbg_process_control_packet...
Checking PATCH 20/43: windbg: implemented windbg_process_data_packet...
Checking PATCH 21/43: windbg: implemented windbg_process_manipulate_packet...
Checking PATCH 22/43: windbg: implemented kd_api_read_virtual_memory and 
kd_api_read_virtual_memory...
Checking PATCH 23/43: windbg: kernel's structures...
Checking PATCH 24/43: windbg: implemented kd_api_get_context and 
kd_api_set_context...
Checking PATCH 25/43: windbg: implemented kd_api_read_control_space and 
kd_api_write_control_space...
Checking PATCH 26/43: windbg: implemented windbg_read_context...
Checking PATCH 27/43: windbg: implemented windbg_write_context...
Checking PATCH 28/43: windbg: implemented windbg_read_ks_regs...
Checking PATCH 29/43: windbg: implemented windbg_write_ks_regs...
Checking PATCH 30/43: windbg: implemented windbg_set_sr...
Checking PATCH 31/43: windbg: implemented windbg_set_dr...
Checking PATCH 32/43: windbg: implemented windbg_set_dr7...
Checking PATCH 33/43: windbg: implemented windbg_hw_breakpoint_insert and 
windbg_hw_breakpoint_remove...
Checking PATCH 34/43: windbg: implemented kd_api_write_breakpoint and 
kd_api_restore_breakpoint...
Checking PATCH 35/43: windbg: debug exception subscribing...
Checking PATCH 36/43: windbg: implemented kd_api_continue...
Checking PATCH 37/43: windbg: implemented kd_api_read_io_space and 
kd_api_write_io_space...
Checking PATCH 38/43: windbg: implemented kd_api_read_physical_memory and 
kd_api_write_physical_memory...
Checking PATCH 39/43: windbg: implemented kd_api_get_version...
Checking PATCH 40/43: windbg: implemented kd_api_read_msr and 
kd_api_write_msr...
Checking PATCH 41/43: windbg: implemented kd_api_search_memory...
Checking PATCH 42/43: windbg: implemented kd_api_fill_memory...
Checking PATCH 43/43: windbg: implemented kd_api_query_memory...
=== OUTPUT END ===

Test command exited with code: 1


---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to address@hidden