Re: [Qemu-devel] [PULL 08/24] iotests: Print full path of bad output if mismatch

[Eric Blake]

On 09/26/2017 09:21 AM, Kevin Wolf wrote:
> From: Fam Zheng <address@hidden>
> 
> So it is easier to copy paste the path.
> 
> Signed-off-by: Fam Zheng <address@hidden>
> Signed-off-by: Kevin Wolf <address@hidden>
> ---
>  tests/qemu-iotests/check | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
> index d504b6e455..4583a0c269 100755
> --- a/tests/qemu-iotests/check
> +++ b/tests/qemu-iotests/check
> @@ -353,7 +353,7 @@ do
>                  else
>                      echo " - output mismatch (see $seq.out.bad)"
>                      mv $tmp.out $seq.out.bad
> -                    $diff -w "$reference" $seq.out.bad
> +                    $diff -w "$reference" $(realpath $seq.out.bad)

This missed my review comments about being unsafe if $PWD contains spaces:
https://lists.gnu.org/archive/html/qemu-devel/2017-09/msg04241.html

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org

signature.asc
Description: OpenPGP digital signature