Re: [Qemu-devel] [RFC PATCH] tests/docker/run: don't source /etc/profile

[Philippe Mathieu-Daudé]

On 09/26/2017 10:36 AM, Alex Bennée wrote:
> The usual behaviour of /etc/profile is to set the default PATH for
> users. This runs into problems when we have updated PATH in our
> dockerfile e.g. to access a cross-compiler in a non-standard
> location. It shouldn't be needed anyway as we inherit the env from the
> image when it was setup.
>
> Signed-off-by: Alex Bennée <address@hidden>

Reviewed-by: Philippe Mathieu-Daudé <address@hidden>

> ---
>   tests/docker/run | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/tests/docker/run b/tests/docker/run
> index c8f940de15..b87f8ef03c 100755
> --- a/tests/docker/run
> +++ b/tests/docker/run
> @@ -18,7 +18,6 @@ fi
>   BASE="$(dirname $(readlink -e $0))"
>   
>   # Prepare the environment
> -. /etc/profile
>   export PATH=/usr/lib/ccache:$PATH
>   
>   if test -n "$J"; then