[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 4/5] scripts: Remove debug parameter from QEMUMo
From: |
Daniel P. Berrange |
Subject: |
Re: [Qemu-devel] [PATCH 4/5] scripts: Remove debug parameter from QEMUMonitorProtocol |
Date: |
Wed, 27 Sep 2017 14:20:52 +0100 |
User-agent: |
Mutt/1.9.0 (2017-09-02) |
On Wed, Sep 27, 2017 at 10:03:38AM -0300, Eduardo Habkost wrote:
> Use logging module for the QMP debug messages. The only scripts
> that set debug=True are iotests.py and guestperf/engine.py, and
> they already call logging.basicConfig() to set up logging.
>
> Scripts that don't configure logging are safe as long as they
> don't need debugging output, because debug messages don't trigger
> the "No handlers could be found for logger" message from the
> Python logging module.
>
> Scripts that already configure logging but don't use debug=True
> (e.g. scripts/vm/basevm.py) will get QMP debugging enabled for
> free.
>
> Cc: "Alex Bennée" <address@hidden>
> Cc: Fam Zheng <address@hidden>
> Cc: "Philippe Mathieu-Daudé" <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> scripts/qemu.py | 3 +--
> scripts/qmp/qmp.py | 13 ++++++-------
> 2 files changed, 7 insertions(+), 9 deletions(-)
Reviewed-by: Daniel P. Berrange <address@hidden>
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
- Re: [Qemu-devel] [PATCH 1/5] guestperf: Configure logging on all shell frontends, (continued)
[Qemu-devel] [PATCH 5/5] scripts: Remove debug parameter from QEMUMachine, Eduardo Habkost, 2017/09/27