[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default config
From: |
Eric Blake |
Subject: |
Re: [Qemu-devel] [PATCH v3 2/2] vl: Print warning when a default config file is loaded |
Date: |
Wed, 27 Sep 2017 15:47:18 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/27/2017 03:41 PM, Eduardo Habkost wrote:
> In case there were options set in the default config file, print
> a warning so users can update their scripts.
>
> If somebody wants to keep the config file as-is, avoid the
> warning and use a command-line that will work in future QEMU
> versions, they can use:
>
> $QEMU -no-user-config -readconfig /etc/qemu/qemu.conf
>
> I was going to add an additional message suggesting it as a
> solution, but I thought it could make it more confusing. The
> solution can be documented in the QEMU 2.11 ChangeLog.
>
> Reviewed-by: Markus Armbruster <address@hidden>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
> Changes v2 -> v3:
> * Rebase (no code changes)
> * Commit message update: suggest -no-user-config
> + if (ret > 0) {
> + loc_set_none();
> + error_report("Warning: Future QEMU versions won't load %s
> automatically",
> + CONFIG_QEMU_CONFDIR "/qemu.conf");
Shouldn't we now use warn_report() with no 'Warning:' prefix?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature