[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return numbe
|
From: |
Eric Blake |
|
Subject: |
Re: [Qemu-devel] [PATCH v3 1/2] config: qemu_config_parse() return number of config groups |
|
Date: |
Wed, 27 Sep 2017 15:49:55 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 09/27/2017 03:41 PM, Eduardo Habkost wrote:
> Change qemu_config_parse() to return the number of config groups
> in success and -EINVAL on error. This will allow callers of
> qemu_config_parse() to check if something was really loaded from
> the config file.
>
> All existing callers of qemu_config_parse() and
> qemu_read_config_file() only check if the return value was
> negative, so the change shouldn't affect them.
>
> Signed-off-by: Eduardo Habkost <address@hidden>
> ---
Reviewed-by: Eric Blake <address@hidden>
> Changes v2 -> v3:
> * None (rebase only)
>
> Changes v1 -> v2:
> * Remove unnecessary translation of qemu_config_parse()
> erros to -EINVAL at block/blkdebug.c:read_config()
> * Suggsted-by: Markus Armbruster <address@hidden>
Do you want the Suggested-by (spelled correctly) in the commit body proper?
--
Eric Blake, Principal Software Engineer
Red Hat, Inc. +1-919-301-3266
Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature