Re: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT submodule

[Daniel P. Berrange]

On Thu, Sep 28, 2017 at 01:53:25AM -0700, address@hidden wrote:
> Hi,
> 
> This series failed build test on s390x host. Please find the details below.
> 
> Type: series
> Subject: [Qemu-devel] [PATCH v6 0/6] Initial support for keycodemapdb GIT 
> submodule
> Message-id: address@hidden

[snip]

>   GIT     ui/keycodemapdb
>   GEN     config-host.h
>   GEN     x86_64-linux-user/config-devices.mak
>   GEN     qemu-options.def
>   GEN     qmp-commands.h
>   GEN     qapi-types.h
>   GEN     qapi-visit.h
>   GEN     qapi-event.h
>   GEN     qmp-marshal.c
>   GEN     qapi-types.c
>   GEN     qapi-visit.c
>   GEN     qapi-event.c
>   GEN     qmp-introspect.h
>   GEN     qmp-introspect.c
>   GEN     trace/generated-tcg-tracers.h
>   GEN     trace/generated-helpers-wrappers.h
>   GEN     trace/generated-helpers.h
>   GEN     trace/generated-helpers.c
>   GEN     module_block.h
> make: *** No rule to make target 'ui/input-keymap-linux-to-qcode.c', needed 
> by 'Makefile'.  Stop.
> make: *** Waiting for unfinished jobs....


What's happened here is that the 'GIT ui/keycodemapdb' checout has not
completed by the time it tries to buil ui/input-keymap-linux-to-qcode.c

Makefile depends on 'git-submodule-update', and Makefile also depends
on $(GENERATED_FILES). IOW the checkout of the git submodules is not
serialized wrt generation of files that use the submodule, and the
patchew test had high enough parallelization to show this flaw, which
my local & Travis tests did not see.

So I need to tweak the deps a little...

Regards,
Daniel
-- 
|: https://berrange.com      -o-    https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org         -o-            https://fstop138.berrange.com :|
|: https://entangle-photo.org    -o-    https://www.instagram.com/dberrange :|